Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude tests in packaging #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marijncv
Copy link

closes #39

Copy link
Owner

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you for opening a merge request. I'm not sure this is the way to go. Distributing tests is a good practice (even if on package that are downloaded a lot it seems like a big waste of resource seeing almost no one launch the tests). It would be better to modify the architecture so the collision problem disappear (by moving the tests dir inside pysankey for example.)

@@ -33,3 +33,7 @@ test =
coveralls
pre-commit
pytest-cov

[options.packages.find]
where=.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default

Suggested change
where=.


[options.packages.find]
where=.
exclude = tests*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's include instead.

Suggested change
exclude = tests*
include = ["pysankey*"]

We could do this is we want to move the tests dir inside the pysankey directory:

Suggested change
exclude = tests*
include = ["pysankey*"]
exclude = ["pysankey.tests*"]

But removing the tests directory is not consensual, I've been asked to add it on other projects.

@Pierre-Sassoulas Pierre-Sassoulas added this to the 1.4.1 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude tests from published wheel
2 participants