* Auto release when LegacyYouTubePlayerView is detached from window #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change listeners in NetworkObservers from List to Set to avoid duplicated listeners
|
Thanks for the PR! I will take a look over the weekend :) |
|
i think this pr have bug |
@billdizl Can you point out the issue ? |
|
yes , i will use ur demo for u show u problem |
|
use @PierfrancescoSoffritti lib demo 1714fec9d714f7a715110557f6e6009f.mp4use ur demo lib to show: 675289d2fdab01d22125c3659cc33f89.mp4Have you found any issues through comparison????@hoangthan |
|
@hoangthan hoangthan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1058
This PR will make the release function is called automatically. So developer who use this lib can put the view in Fragment, View... without care about bind the view to a lifecycleOwner