Introduce TestNG to JUnit migration module [DRAFT] #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
changed the title
rickie
changed the title
rickie
changed the title
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
reviewed
Feb 23, 2023
...ng-junit-migrator/src/main/java/tech/picnic/errorprone/testngjunit/TestNGJUnitMigration.java
Outdated
Show resolved
Hide resolved
...ng-junit-migrator/src/main/java/tech/picnic/errorprone/testngjunit/TestNGJUnitMigration.java
Outdated
Show resolved
Hide resolved
error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java
Outdated
Show resolved
Hide resolved
rickie
reviewed
Feb 23, 2023
testng-junit-migrator/src/main/java/tech/picnic/errorprone/testngjunit/TestNGScanner.java
Outdated
Show resolved
Hide resolved
...unit-migrator/src/test/java/tech/picnic/errorprone/testngjunit/TestNGJUnitMigrationTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/tech/picnic/errorprone/testngjunit/argument/PriorityArgumentMigratorTest.java
Outdated
Show resolved
Hide resolved
testng-junit-migrator/src/test/java/tech/picnic/errorprone/testngjunit/TestNGScannerTest.java
Outdated
Show resolved
Hide resolved
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
2 similar comments
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
1 similar comment
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
force-pushed
the
gdejong/testng-migrator
branch
from
0dadcce
to
405b917
Compare
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
1 similar comment
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
1 similar comment
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
rickie
reviewed
Mar 20, 2023
|
|
||
| # Use the Maven Wrapper executable if present. | ||
| MVN='mvn' | ||
| if [ -x ./mvnw ]; then |
There was a problem hiding this comment.
We don't need to do this. We have this internally but there is a thread where someone mentioned it is not best practice.
| echo "Number of JUnit tests run: $junit_results" | ||
| echo "Difference: $(expr ${testng_results} - ${junit_results})" | ||
|
|
||
| echo "Finished migration steps!" |
There was a problem hiding this comment.
Will add a few tweaks to the script and strings :).
| import org.junit.jupiter.api.Test; | ||
|
|
||
| // Should be de-duplicated in the future, for example by depending on `error-prone-contrib` | ||
| final class SourceCodeTest { |
There was a problem hiding this comment.
Hmm, we discussed this offline a few times. Let's drop it because it tests something we do not really use.
|
|
||
| final class TestNGMatchersTest { | ||
| @Test | ||
| void nGAnnotation() { |
There was a problem hiding this comment.
There is some overlap here, we can combine the tests :). Will push a proposal.
…` with additional `$grep_command` usage alignment
rickie
force-pushed
the
gdejong/testng-migrator
branch
from
56d5889
to
a6b2e31
Compare
rickie
force-pushed
the
gdejong/testng-migrator
branch
from
4653141
to
83428da
Compare
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
|
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT