Allow opencv8 distortion model in PhotonCamera #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bankst
approved these changes
May 11, 2024
|
Is there a usecase for leaving the vector length unspecified instead of just changing 5 to 8 everywhere? |
|
Opencv calibration is still set to opencv5. We could standardize on 8, maybe? Or can we just set higher level coefficients to zero? |
👍 |
mcm001
force-pushed
the
cam-variable-length-distortion
branch
from
064b94e
to
38d7201
Compare
mcm001
force-pushed
the
cam-variable-length-distortion
branch
from
38d7201
to
5edc3b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously assumed only OpenCV5 but mrcal uses opencv8