Use ReadQueue for PhotonCamera timestamps #1316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcm001
force-pushed
the
getatomic-lib
branch
4 times, most recently
from
37e3f47
to
a455ac2
Compare
|
What's the overhead of enabling poll storage? If it's somewhat decent we should make this a configurable option when actually creating the camera. |
|
It just makes the circular buffer of std vectors of bytes larger. Since the contents of the vector are dynamically allocated, the cost is zero, and then as you push more new packets in, you allocate new memory. So probably on the order of 20kb, at worst, of dynamically allocated memory, and 20*sizeof(vector) statically? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the extra GetLastChange call to keep everything properly atomic.
Closes #1303