Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use package from activity context to support compose #2590

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GoodSir42
Copy link

this fixes #2371 by using the bundle ID from the activity as a fallback. You might make this the default package ID and just treat this PR as a general hint in which direction to go. let me know if you need any further input on this matter.

It would be absolutely great to have compose support as I personally like the UI framework a lot :)

@PhilippC
Copy link
Owner

@GoodSir42 thanks for providing the PR! Is it intentional that you use the "fallback" immediately on the first level of recursion? Wouldn't it be more backward compatible to call ParseRecursive and afterwards use the _structure.ActivityComponent.PackageName if no PackageId was found?

@GoodSir42
Copy link
Author

@PhilippC yes, that actually sounds far more reasonable 😄 C# is not my strong language and as I said it's probably best to use the PR as an inspiration with more knowledge about the project rather than merging it as is.
The general idea was to determine the fallback bundle ID if nothing else could be found rather than androidapp://

@GoodSir42
Copy link
Author

I updated the PR so that the fallback will only be used if no information could be parsed from the structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Android Compose + KP2A Autofill
2 participants