[Relies on #263] Style update #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 16, 2018 22:56
Philip-Scott
requested changes
Mar 17, 2018
There was a problem hiding this comment.
Hey! Thanks again for helping me make Notes-Up even better!
Like you said, this branch relies on your other PR which i've already reviewed, so you should check that first ;) But i also left a couple of reviews in this PR
If you have any questions feel free to leave a comment and reach out to me!
data/stylesheet.css
Outdated
| @@ -1,3 +1,15 @@ | |||
| .title-label { | |||
| font-size:1em; | |||
| /* font-size: 1.15em; | |||
There was a problem hiding this comment.
Don't leave commented code :)
| @@ -91,7 +91,7 @@ | |||
| </key> | |||
|
|
|||
| <key name="editor-font" type="s"> | |||
| <default>"Open Sans 12"</default> | |||
| <default>"Open Sans 10"</default> | |||
There was a problem hiding this comment.
I thought it was more in line with how fonts on the system are sized, I can change it back if you don't like it/don't think it's good.
src/Widgets/PageItem.vala
Outdated
| @@ -37,43 +37,45 @@ public class ENotes.PageItem : Gtk.ListBoxRow { | |||
| private void build_ui () { | |||
| set_activatable (true); | |||
|
|
|||
| var margin_horizontal = 10; | |||
There was a problem hiding this comment.
- If we're going to use a constant, you should declare it at the very top of the class as
private const int HORIZONTAL_MARGIN = 10 - Why the 10? why not something like 6 or 12? (12 is actually the number recommended over at the elementary Human Interface Guidelines: https://elementary.io/docs/human-interface-guidelines#spacing
added 7 commits
March 18, 2018 19:04
…g and made translatable
…ot currently working)
…izontal margins to 12
|
ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #258
Relies on #263
Requires running
cmake -DCMAKE_INSTALL_PREFIX=/usr ../(in build directory)Changes made in this pull request:
Preview:
(the gap is fixed in another PR)