Fast exit undef/empty strings in Data::Dumper::qquote()

[DabeDotCom]

This silences a squajillion (okay, five) "uninitialized" warnings, and is more efficient, anyway...

[jkeenan]

This silences a squajillion (okay, five) "uninitialized" warnings, and is more efficient, anyway...

Can you provide an example of how you are getting these uninitialized warnings? Thanks.

[tonycoz]

I don't see any such warnings in the build, and Data::Dumper itself should never call qquote() with undef that I can see.

[DabeDotCom]

Can you provide an example of how you are getting these uninitialized warnings? Thanks.

Sorry, I totally cheated and called it from outside... (Text::Quote mentions taking "inspiration" from Data::Dump, but I figured since Data::Dumper was a core module, I'd just leverage *it* instead.)

prompt% perl -MData::Dumper -E 'say Data::Dumper::qquote()'
Use of uninitialized value $_ in substitution (s///) at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 764.
Use of uninitialized value in numeric gt (>) at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 775.
Use of uninitialized value $bytes in numeric gt (>) at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 775.
Use of uninitialized value $_ in pattern match (m//) at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 783.
Use of uninitialized value $_ in concatenation (.) or string at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 783.
""

Anyway, I know it's undocumented, and I'm okay if it breaks, but I figured I'd push my (trivial) optimization back upstream, just in case you were interested. «shrug»

Cheers! :-D

[demerphq]

On Mon, 11 Mar 2024 at 17:37, DabeDotCom ***@***.***> wrote: Can you provide an example of how you are getting these uninitialized warnings? Thanks. Sorry, I totally cheated and called it from outside... (Text::Quote <https://metacpan.org/pod/Text::Quote> mentions taking "inspiration" from Data::Dump, but I figured since Data::Dumper was a core module, I'd just leverage *it* instead.) prompt% perl -MData::Dumper -E 'say Data::Dumper::qquote()' Use of uninitialized value $_ in substitution (s///) at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 764. Use of uninitialized value in numeric gt (>) at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 775. Use of uninitialized value $bytes in numeric gt (>) at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 775. Use of uninitialized value $_ in pattern match (m//) at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 783. Use of uninitialized value $_ in concatenation (.) or string at /System/Library/Perl/5.34/darwin-thread-multi-2level/Data/Dumper.pm line 783. "" Anyway, I know it's undocumented, and I'm okay if it breaks, but I figured I'd push my (trivial) optimization back upstream, just in case you were interested. «shrug» Cheers! :-D

IMO there is nothing wrong with hardening DD::qquote() to undef input. It may technically be undocumented, in practice ive seen it used many times. Cheers Yves

…

-- perl -Mre=debug -e "/just|another|perl|hacker/"

[tonycoz]

I think it could use a test or two (simple non-empty string, empty string, undef), otherwise it's good.