Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Spider Plus Module Catch NetBios Timeout #267

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix: Spider Plus Module Catch NetBios Timeout #267

wants to merge 4 commits into from

Conversation

Marshall-Hallenbeck
Copy link
Collaborator

  • Catch NetBIOSTimeout error
  • fixed some erroneous extra lines

@Marshall-Hallenbeck Marshall-Hallenbeck added the bug-fix This Pull Request fixes a bug label Apr 19, 2024
@Marshall-Hallenbeck Marshall-Hallenbeck self-assigned this Apr 19, 2024
mpgn
mpgn previously approved these changes Apr 19, 2024
View reviewed changes
NeffIsBack
NeffIsBack previously approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marshall-Hallenbeck
Copy link
Collaborator Author

There's an infinite loop with the reconnect function since if it times out, then it re-calls the login which then leads to the list being recalled, and around and around, so I need to fix that. I might just remove the reconnect or just try to reconnect once since right now it tries 5 times which is excessive anyway (it prints the protocol login message too).

@Marshall-Hallenbeck Marshall-Hallenbeck marked this pull request as draft April 20, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpgn mpgn mpgn left review comments

@NeffIsBack NeffIsBack NeffIsBack left review comments

@zblurx zblurx Awaiting requested review from zblurx zblurx is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@Marshall-Hallenbeck Marshall-Hallenbeck

Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Marshall-Hallenbeck @mpgn @NeffIsBack