Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passwords dump update #225

Merged
merged 31 commits into from May 25, 2024
Merged

Passwords dump update #225

merged 31 commits into from May 25, 2024
+722 −17

Conversation

zblurx
Copy link
Collaborator

@zblurx zblurx commented Mar 22, 2024

This PR aims to implement new secrets looting. For now :

  • Google Refresh Token
  • SCCM
  • VNC

@NeffIsBack NeffIsBack added the enhancement New feature or request label Mar 22, 2024
@zblurx
Copy link
Collaborator Author

zblurx commented Mar 28, 2024

Now support also mRemoteNG password dump

@zblurx zblurx marked this pull request as ready for review March 28, 2024 13:18
@NeffIsBack NeffIsBack added new module reviewed code Label for when a static code review was done labels Mar 29, 2024
@zblurx
Copy link
Collaborator Author

zblurx commented Apr 3, 2024

And now support MobaXterm password dump

@NeffIsBack NeffIsBack added this to the v1.2.0 milestone Apr 23, 2024
@Marshall-Hallenbeck
Copy link
Collaborator

@zblurx can you add these commands to the e2e tests?

@NeffIsBack
Copy link
Contributor

mremoteng working 🚀
image

@NeffIsBack
Copy link
Contributor

First run (with registry) works, second one (using config file as storage method) doesn't @zblurx
image

@NeffIsBack
Copy link
Contributor

NeffIsBack commented May 5, 2024 •
edited

Got vnc setup working now. Added a check for realvnc's proxy credentials. There is bug with the password decryption only showing 8 characters though. image

EDIT: UltraVNC only supports passwords up to 8 characters yikes. The rest is just cut off without any warning

Fixed the truncated passwords when decrypting:
image

Marshall-Hallenbeck
Marshall-Hallenbeck requested changes May 21, 2024
View reviewed changes
nxc/modules/mremoteng.py Outdated Show resolved Hide resolved
nxc/modules/vnc.py Outdated Show resolved Hide resolved
nxc/modules/mremoteng.py Outdated Show resolved Hide resolved
nxc/modules/vnc.py Show resolved Hide resolved
tests/e2e_commands.txt Outdated Show resolved Hide resolved
tests/e2e_commands.txt Outdated Show resolved Hide resolved
@NeffIsBack
Copy link
Contributor

SCCM working flawless now 🚀
image
Tomorrow i will test the googleRefreshToken stuff and we should be good2go 🎉

@mpgn mpgn mentioned this pull request May 22, 2024
Merged
mpgn
mpgn previously approved these changes May 22, 2024
View reviewed changes
@NeffIsBack NeffIsBack mentioned this pull request May 22, 2024
Merged
NeffIsBack
NeffIsBack previously approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't get chrome dump to work, but it works on @zblurx system. Maybe i fcked something up in the setup process, but for me that's enough, everything else is working as intended.

LGTM, @zblurx press that merge button 🚀

@Marshall-Hallenbeck
Merge branch 'main' into passwords_dump_update
f060aeb 
Signed-off-by: Marshall Hallenbeck <Marshall.Hallenbeck@gmail.com>
@Marshall-Hallenbeck Marshall-Hallenbeck dismissed stale reviews from NeffIsBack, mpgn, and themself via f060aeb May 24, 2024 14:58
@Marshall-Hallenbeck
Copy link
Collaborator

Fixed the conflict that occurred because of my arg parse refactor, should be good now, it was just the --sccm flag needed to be added with the other cred options

@zblurx zblurx merged commit ad923f8 into main May 25, 2024
6 checks passed
@zblurx zblurx deleted the passwords_dump_update branch May 25, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marshall-Hallenbeck Marshall-Hallenbeck Marshall-Hallenbeck approved these changes

@mpgn mpgn mpgn left review comments

@NeffIsBack NeffIsBack NeffIsBack left review comments

Assignees
No one assigned
Labels
enhancement New feature or request new module reviewed code Label for when a static code review was done
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zblurx @Marshall-Hallenbeck @NeffIsBack @mpgn