-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNS] Add DNS args #196
[DNS] Add DNS args #196
Conversation
awesome, you did it ! 🎉 |
Tested working for me
|
@mpgn current is not ready, I want to play with kdchost, it would be useful |
This is amazing! It finally solves the dns problem, even without setting a dns server! |
MSSQL Current is not changed, will change it after #136 is merged |
@XiaoliChan yo this is awesome! |
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
Signed-off-by: XiaoliChan <30458572+XiaoliChan@users.noreply.github.com>
@NeffIsBack I started looking at renaming the variables and unfortunately it's just everywhere. I think we should create an issue to fix the naming conventions everywhere, and just merge this PR as it. |
Then let's rename the newly created variables to use the old ones. I just don't want to have duplicate variables. |
Not going to update it myself. I'll fix it across the project after this is merged. |
@XiaoliChan i removed the remoteHost variable for now and made some formatting changes. Can you check if everything looks good to you? |
@Marshall-Hallenbeck can you run the test suite against the PR? Just to make sure there didn't something which i missed with the manual review & testing. The last fix (see above) can be tested manually when fixed. |
I ran it before, but I can run it again. Just gotta make sure the new test cases are in the e2e tests. |
Fixed some final stuff and running tests now |
I think 95ac1af destroyed the normal login 😅 |
Yeah it did... lemme try to fix it lol. |
…, move Impacket silencing, add debugging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit 47b1c1f solved remaining issue:
Tests ran through fine now. @Marshall-Hallenbeck would merge now if there isn't anything left to do
Tests look good from my side, merging now. It's been a long time coming and I'm excited to finally get this in! |
Changelog:
kdcHost
-6
--dns-server
tcp
DNS query with--dns-tcp
--dns-timeout
/etc/hosts
files