Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Pass capabilities to the decomposer #749

Merged
merged 36 commits into from
May 27, 2024

Conversation

grwlf
Copy link
Contributor

@grwlf grwlf commented May 16, 2024

Context: Catalyst needs to deal with operations which are not supported by the target device. This PR addresses decomposition-to-matrix branch.

Description of the Change: We read gates to be decomposed to matrix from the device capabilities (which in turn are described in the device toml file).
[sc-62011]

Benefits: Device authors gain control over the decomposition strategies

Possible Drawbacks:

Related GitHub Issues:
Requires #712

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (2636257) to head (2a218dc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
- Coverage   98.07%   98.06%   -0.01%     
==========================================
  Files          70       69       -1     
  Lines        9601     9512      -89     
  Branches      756      756              
==========================================
- Hits         9416     9328      -88     
+ Misses        151      150       -1     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grwlf grwlf marked this pull request as ready for review May 21, 2024 12:54
@lillian542 lillian542 changed the base branch from main to toml-schema-2-update-test May 21, 2024 17:14
doc/changelog.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a few minor comments.

frontend/catalyst/utils/libcustom_calls.cpp Outdated Show resolved Hide resolved
frontend/test/pytest/test_jax_dynamic_api.py Outdated Show resolved Hide resolved
frontend/test/pytest/test_jax_numerical.py Outdated Show resolved Hide resolved
frontend/test/pytest/test_preprocess.py Show resolved Hide resolved
@grwlf grwlf changed the base branch from toml-schema-2-update-test to main May 22, 2024 10:57
Copy link

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@grwlf grwlf requested a review from lillian542 May 22, 2024 13:23
Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@grwlf grwlf merged commit 8c42cc9 into main May 27, 2024
37 of 38 checks passed
@grwlf grwlf deleted the decompose-to-matrix-using-capabilities branch May 27, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants