Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Fix decomposition tests #745

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

erick-xanadu
Copy link
Contributor

@erick-xanadu erick-xanadu commented May 15, 2024

Context: Recent changes in the TOML files broke some tests.

Description of the Change: Fix those tests.

Benefits: Latest/latest/latest passes again (at least for lightning.qubit).

Comment:

The minimum version of pennylane-lightning required is 0.37.0-dev7 but those wheels failed to be uploaded. I have used 0.37.0-dev9. If the minimum version required is required for this PR, let me know and I will ask the team to push wheels for -dev7

[sc-63376]

@erick-xanadu erick-xanadu added the ci:build-wheels Run the wheel building workflows on this Pull Request label May 15, 2024
@erick-xanadu erick-xanadu force-pushed the eochoa/2024-05-15/fix-decomposition branch from 709230f to 8c5b54b Compare May 15, 2024 15:16
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.08%. Comparing base (0dc7538) to head (02a2211).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #745      +/-   ##
==========================================
- Coverage   98.10%   98.08%   -0.03%     
==========================================
  Files          69       69              
  Lines        9550     9550              
  Branches      746      746              
==========================================
- Hits         9369     9367       -2     
- Misses        147      148       +1     
- Partials       34       35       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erick-xanadu erick-xanadu changed the title Fix decomposition [Frontend] Fix decomposition tests May 15, 2024
@erick-xanadu erick-xanadu requested a review from grwlf May 15, 2024 20:22
doc/changelog.md Outdated Show resolved Hide resolved
doc/changelog.md Outdated Show resolved Hide resolved
@erick-xanadu erick-xanadu requested a review from dime10 May 15, 2024 21:17
Copy link

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@dime10
Copy link
Collaborator

dime10 commented May 15, 2024

I'm not sure how much of this PR is clashing with #718 and #712, could you double check?

@erick-xanadu
Copy link
Contributor Author

I'm not sure how much of this PR is clashing with #718 and #712, could you double check?

I'm happy to close this PR without merging if #718 and #712 would fix latest/latest/latest.

@grwlf
Copy link
Contributor

grwlf commented May 23, 2024

I'm not sure how much of this PR is clashing with #718 and #712, could you double check?

I'm happy to close this PR without merging if #718 and #712 would fix latest/latest/latest.

We need #712 . I would suggest to merge it instead of this PR. #712 addresses exactly this issue, but in my opinion - in a more systematic way: it adds an option to modify capabilities directly so we no longer need to stick to a particular toml syntax in tests.

The #718 fixes another toml leftover, it requires #712 as a prerequisite.

@dime10
Copy link
Collaborator

dime10 commented May 23, 2024

I'm not sure how much of this PR is clashing with #718 and #712, could you double check?

I'm happy to close this PR without merging if #718 and #712 would fix latest/latest/latest.

We need #712 . I would suggest to merge it instead of this PR. #712 addresses exactly this issue, but in my opinion - in a more systematic way: it adds an option to modify capabilities directly so we no longer need to stick to a particular toml syntax in tests.

The #718 fixes another toml leftover, it requires #712 as a prerequisite.

Let's give those PRs the final push! @grwlf can you ensure relevant discussions are resolved with the reviewers and merged this week?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build-wheels Run the wheel building workflows on this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants