[Frontend] Adds fwd and bwd to pure_callbacks #743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erick-xanadu
changed the title
erick-xanadu
force-pushed
the
eochoa/2024-05-14/callbacks-frontend-ii
branch
from
1e9bcaa
to
c1c150a
Compare
erick-xanadu
changed the base branch from
main
to
eochoa/2024-05-09/specialize-callbacks-part-two
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## eochoa/2024-05-09/specialize-callbacks-part-two #743 +/- ##
===================================================================================
- Coverage 98.07% 97.87% -0.20%
===================================================================================
Files 70 70
Lines 9603 9659 +56
Branches 757 764 +7
===================================================================================
+ Hits 9418 9454 +36
- Misses 151 168 +17
- Partials 34 37 +3 ☔ View full report in Codecov by Sentry. |
|
Closed in favour of #788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Changes in the frontend to support
fwdandbwdinpure_callbacksDescription of the Change: Class that will contain
fwdandbwdalong with the minimal sufficient support with MLIR.Related GitHub Issues: Depends on #742, #735 (The first commit are these two prs squashed, which is what we will see when they are merged. When these are merged, I will just drop and rebase).
(This is marked as work in progress to prioritize review on #735)
[sc-60499]