Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Runtime] Add support for Lightning source directory to be used in runtime build #732

Merged
merged 9 commits into from
May 23, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented May 10, 2024

Context: This PR allows Lightning to be cloned and used in-place with Catalyst's runtime, allowing faster turnaround and development against both packages. In addition, it overcomes some issues with Python package issues observed at build time by updating the runtime pybind11 and requiring Python to be found before proceeding.<\del>

Description of the Change: Added LIGHTNING_SRC_PATH CMake argument to specify a full path to a local Lightning repository, and all source will be used in place for a runtime build.

Benefits: Enables faster turnaround for development between Lightning and Catalyst. Can allow a multi-version clone of each repo and compilation steps to be validated and tested.

Possible Drawbacks:

Related GitHub Issues:

@mlxd
Copy link
Member Author

mlxd commented May 10, 2024

[sc-63110]

@mlxd mlxd changed the title Update/lightning build path [Runtime] Add support for Lightning source directory to be used in runtime build May 10, 2024
@mlxd mlxd requested a review from maliasadi May 10, 2024 19:49
@mlxd mlxd marked this pull request as ready for review May 10, 2024 19:49
runtime/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link

Hello. You may have forgotten to update the changelog!
Please edit doc/changelog.md on your branch with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

runtime/CMakeLists.txt Outdated Show resolved Hide resolved
runtime/CMakeLists.txt Outdated Show resolved Hide resolved
@mlxd
Copy link
Member Author

mlxd commented May 10, 2024

Exploring whether PennyLaneAI/pennylane-lightning#725 will fix Kokkos failures

UPDATE: No further LK issues.

@mlxd mlxd requested review from maliasadi and dime10 May 17, 2024 18:26
Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve 💯 Would love to figure the pybind/findpython issue at some point though if you have time.

@mlxd
Copy link
Member Author

mlxd commented May 17, 2024

Happy to approve 💯 Would love to figure the pybind/findpython issue at some point though if you have time.

Sounds good. Yea, I'll do some delving once time permits.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlxd! This would be also beneficial for testing the runtime with pre-compiled Kokkos kernels 🚀

@mlxd mlxd merged commit 1cfdd30 into main May 23, 2024
37 checks passed
@mlxd mlxd deleted the update/lightning_build_path branch May 23, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants