[MLIR] Mark debug.callbacks as inactive functions.
#706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PythonCallOp`s are lowered into LLVM functions. This commit introduces the change that `PythonCallOp`s are lowered into LLVM functions which are annotated with the `catalyst.debugCallback` attribute. The reason for this is that without this attribute, the only way to determine if an LLVM call corresponds to a function call to `@pyregistry` with a third parameter set to zero. To avoid having to find the definition of the third parameter (which may have been defined in a different function), we annotate during the lowering. This case is likely not going to happen in the current state of the compiler, since it would depend on outlining. But, it is still a good change to make since it reduces compilation time having to traverse the use-def chain.
[skip ci]
[skip ci]
erick-xanadu
force-pushed
the
eochoa/2024-05-01/specialize-callbacks
branch
from
2fb0255
to
bb78de4
Compare
erick-xanadu
changed the title
debug.callbacks as inactive functions.debug.callbacks as inactive functions.
dime10
reviewed
May 22, 2024
mlir/lib/Catalyst/Transforms/AnnotateDebugCallbackAsEnzymeConstPass.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
debug.callbackswill always be inactive functions when taking the gradient of them.Description of the Change: Change
pyregistrytoinactive_callbackand mark allinactive_callbacks as inactive.Benefits: Inactive callbacks are inactive.
Notes:
[sc-60496]