Attempt to build cache using osx target version 12. Added osx target version as cache key #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashidnhm
added
the
ci:build-wheels
rashidnhm
changed the title
|
I think this might be relevant? https://forums.developer.apple.com/forums/thread/739342 Is there a way to verify that the deployment target variable is used correctly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Change the OSX Deployment version to 12, for more backwards compatibility.
Description of the Change:
This PR updates the OSX Deployment target version to a lower value than 14. This is to address compatibility concerns.
Furthermore, the target osx version was added to the cache key for arm. As we want to not use older cache if this target version is updated again.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
None. Shortcut: sc-59543.