Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dummy PR to check GA #3271

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

GandalfGwaihir
Copy link
Collaborator

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@infotroph
Copy link
Member

@GandalfGwaihir I see this is marked as a dummy -- is it finished and OK to close?

@infotroph
Copy link
Member

@GandalfGwaihir BTW I keep a sandbox copy of PEcAn at https://github.com/infotroph/pecan-pr-sandbox to I use for testing things that would otherwise clutter up the main repo -- use it if you'd like, but no obligation.

@GandalfGwaihir
Copy link
Collaborator Author

Hold this please, We have a bug which adds tests label to every PR, I will get to that this month, will close this once the bug is sorted out, and sorry should had posted the update here! good times 🥂

@GandalfGwaihir
Copy link
Collaborator Author

use it if you'd like, but no obligation.

Didn't know that, yeah sure, will test over there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants