Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding package-specific tags in DESCRIPTION files of the model packages #3093

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Parthmadan-1
Copy link
Contributor

This is a WIP PR, kindly provide your suggestions.

@mdietze
Copy link
Member

mdietze commented Jan 23, 2023

Could you provide a more informative PR title and description?

@Parthmadan-1 Parthmadan-1 changed the title Parth Adding package-specific tags in DESCRIPTION files of the model packages Jan 23, 2023
@@ -33,3 +33,5 @@ LazyData: FALSE
Encoding: UTF-8
Require:
RoxygenNote: 7.1.2
X-schema.org-keywords: R, Predictive Ecosystem Analyzer, Carbon, Water, vegetated ecosystem , atmosphere, high speed model, Bruteforce Suitable, SIPNET
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "Bruteforce Suitable"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read this online "SIPNET is a fast model (∼ 5.5 sec per MCMC iteration in PEcAn including model
execution, and writing and reading model outputs), which makes it suitable for application of bruteforce methods."

@Aariq
Copy link
Collaborator

Aariq commented Jan 28, 2023

The purpose of these keywords is so that someone searching for them on r-universe would find our packages. So some of these additions are probably not relevant. Think about a domain scientist looking for a suitable R package for their research. What would they type in to find something like PEcAn.SIPNET? Probably not "bruteforce suitable", but maybe something like "vegetation modeling"

Copy link
Member

@mdietze mdietze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided some suggested changes to tags/keywords. @Parthmadan-1 hopefully you can incorporate these and we can finish up this PR quickly

@@ -40,3 +40,5 @@ LazyLoad: yes
LazyData: FALSE
Encoding: UTF-8
RoxygenNote: 7.1.2
X-schema.org-keywords: R, Predictive Ecosystem Analyzer, plant growth prediction, time, climate, Biofuel Ecophysiological Traits, physiological , biophysical , BIOCRO
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
X-schema.org-keywords: R, Predictive Ecosystem Analyzer, plant growth prediction, time, climate, Biofuel Ecophysiological Traits, physiological , biophysical , BIOCRO
X-schema.org-keywords: Predictive Ecosystem Analyzer, plant growth prediction, crop model, Biofuel Ecophysiological Traits, plant ecophysiology , BIOCRO

@@ -66,3 +66,5 @@ Encoding: UTF-8
RoxygenNote: 7.1.2
Roxygen: list(markdown = TRUE)
Config/testthat/edition: 2
X-schema.org-keywords: R, Predictive Ecosystem Analyzer,Ecosystem Demography, terrestrial biosphere, plant community dynamics, biogeochemical,soil fluxes, Carbon, Water, Nitrogen, SAS approximation, ED2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
X-schema.org-keywords: R, Predictive Ecosystem Analyzer,Ecosystem Demography, terrestrial biosphere, plant community dynamics, biogeochemical,soil fluxes, Carbon, Water, Nitrogen, SAS approximation, ED2
X-schema.org-keywords: Predictive Ecosystem Analyzer, Ecosystem Demography model, terrestrial biosphere model, vegetation demographic model, plant community dynamics, biogeochemistry, Carbon cycle, size- and age-structured approximation, ED2

@@ -33,3 +33,5 @@ LazyData: FALSE
Encoding: UTF-8
Require:
RoxygenNote: 7.1.2
X-schema.org-keywords: R, Predictive Ecosystem Analyzer, Carbon, Water, vegetated ecosystem , atmosphere, high speed model, Bruteforce Suitable, SIPNET
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
X-schema.org-keywords: R, Predictive Ecosystem Analyzer, Carbon, Water, vegetated ecosystem , atmosphere, high speed model, Bruteforce Suitable, SIPNET
X-schema.org-keywords: Predictive Ecosystem Analyzer, Carbon cycle, ecosystem model, SIPNET

@@ -77,3 +77,5 @@ LazyLoad: yes
LazyData: FALSE
Encoding: UTF-8
RoxygenNote: 7.1.2
X-schema.org-keywords: R, Predictive Ecosystem Analyzer, data.atmosphere, meteorological products conversion, climate driver data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
X-schema.org-keywords: R, Predictive Ecosystem Analyzer, data.atmosphere, meteorological products conversion, climate driver data
X-schema.org-keywords: Predictive Ecosystem Analyzer, meteorological data product conversion, climate driver data, downscaling, gap-filling

@@ -48,3 +48,5 @@ LazyData: FALSE
Encoding: UTF-8
RoxygenNote: 7.1.2
Roxygen: list(markdown = TRUE)
X-schema.org-keywords: R, Predictive Ecosystem Analyzer,meta analysis, plant traits, Bayesian
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
X-schema.org-keywords: R, Predictive Ecosystem Analyzer,meta analysis, plant traits, Bayesian
X-schema.org-keywords: Predictive Ecosystem Analyzer, meta-analysis, plant traits, Bayesian

Copy link

github-actions bot commented May 3, 2024

This PR is stale because it has been open 365 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants