Abstract mem disabled fixes #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case this branch/these two commits are merged into PascalCoin then I am requesting 500 pascalcoin from the pascalcoin development fund ! =D
Note1: simply remove CreatePascalCoinRepository.sh after merger and then do a git commit --amend before finally pushing it to remote =D It seems you know how to do this from a previous merger :) So I am not going to bother with a time-costly/tricky rebase just to remove this one file ! Good Luck ! =D
Note2: At least on my special-build I notice PascalCoin will re-download the blockchain everything when AbstractMem is disabled, so disabling AbstractMem may require more work to make it work really well.
Note3: I think it's a good idea to try and keep PascalCoin working without AbstractMem in case AbstractMem contains serious bugs and also to have a non-abstract-mem version for clients and faster execution and perhaps also easier debugging of other code, plus it might also make it easier to PascalCoin for new developers/users, for them AbstractMem might be a little tricky/complex =D After all systems with plenty of RAM might not need AbstractMem at all ! ;)