Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyborg Damage, Movement, and Power Overhaul #25252

Open
wants to merge 53 commits into
base: master
Choose a base branch
from

Conversation

BiancaWilkson
Copy link
Contributor

@BiancaWilkson BiancaWilkson commented Apr 24, 2024

What Does This PR Do

This PR will do a few things.

  • Adds damage slowdown to cyborgs, and increases their base movement speed.
  • Removes all instant stuns from cyborg combat.
  • Adds a tweaked stamina damage to cyborgs, caused by the things that would currently stun them.
  • Reworks how cyborgs without power, or power cells work by making it potentially lethal to run out of power, but giving the borg time to react to losing power, or a power cell.

Exact mechanics of the power overhaul works like this:
The behavior for being de-celled is being merged into running out of charge. Either way, when your power source is gone you begin taking stamina damage every cycle of Life(). Cyborgs in stamcrit need to reboot, and cannot properly reboot without a power source. If the borg doesn't get re-powered by the time it would reboot, they die.

On the movement speed side of the PR, cyborgs start with the normal human movement speed, but as their components take damage or they take stamina damage they slow down. Both damage slowdown effects stack with each other.

EMPs and Flashes no longer instantly stun cyborgs, instead they deal 65 and 35 stamina damage respectively. In return, emagged engineering cyborgs no longer get a special instant-stun arm, and have been downgraded to a normal stunbaton.

While disablers and batons won't deal their stamina damage, ballistic projectiles still would, namely beanbag shells and the C20R.

Reboot_chime sound source: Achievement Accomplish Jingle App UI by CogFireStudios -- https://freesound.org/s/619840/ -- License: Creative Commons 0
shut_down sound source: No battery by DAN2008 -- https://freesound.org/s/710280/ -- License: Creative Commons 0

Why It's Good For The Game

Cyborgs have been a very contentious part of Paradise for the entirety of their existence. Their balance is always in a weird spot, their design has always been in a weird spot, and the playerbase's opinion of them has always been in a weird spot. Especially since the combat rework, everyone generally agreed that cyborgs' instant stun combat was unfun and outdated.
The changes to power come from my experiences being a de-celled cyborg. It's the worst, and having it kill the player is way more preferable to being stuck there. This allows them to stay conscious, while still threatening them and putting them on a timer.

Testing

Some testing, but I need to do more when I actually finish it.

Changelog

🆑
add: Cyborgs can now take stamina damage instead of being instantly stunned, and will need to reboot.
tweak: Cyborgs are conscious but slowly die when out of power, or without a power cell
tweak: Cyborgs now move at full speed, and slow down when they take damage.
tweak: Cyborgs need a power source to be revived.
tweak: You can put dead things inside a recharger.
tweak: Emagged engineering cyborgs now have a regular baton, instead of an instant-stunning arm.
/:cl:

@S34NW S34NW added Feature This PR is a new addition to the game Balance This PR will modify how effective something is or isnt labels Apr 24, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally Configuration Change This PR changes the game configuration files. Please run via the host. labels Apr 24, 2024
@Henri215 Henri215 added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Apr 24, 2024
BiancaWilkson and others added 3 commits April 24, 2024 10:09
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
Co-authored-by: CRUNCH <143041327+Fordoxia@users.noreply.github.com>
@Daylight2
Copy link
Contributor

Am conflicted about this. On one hand, being able to do something about that annoying cyborg chasing you around when you're doing antag stuff is great. On the other hand, being countered by a disabler when you're a nukieborg/malf/emagged/subverted seems like a pretty big nerf to those things.

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Apr 24, 2024
@Fordoxia
Copy link
Contributor

Am conflicted about this. On one hand, being able to do something about that annoying cyborg chasing you around when you're doing antag stuff is great. On the other hand, being countered by a disabler when you're a nukieborg/malf/emagged/subverted seems like a pretty big nerf to those things.

No more funny stun arm ::)

@BiancaWilkson
Copy link
Contributor Author

Am conflicted about this. On one hand, being able to do something about that annoying cyborg chasing you around when you're doing antag stuff is great. On the other hand, being countered by a disabler when you're a nukieborg/malf/emagged/subverted seems like a pretty big nerf to those things.

Gonna update the description to make it more clear, my intent is that the normal sources of stamina damage like disablers and batons still won't be able to harm cyborgs, the stamina system will be used to replace the current ways to instant-stun borgs.

@ParadiseSS13-Bot ParadiseSS13-Bot added the Sound This PR modifies the game sound label May 20, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added the Testmerge Active This PR is currently testmerged on production label May 30, 2024
@TravisAngeI
Copy link

TravisAngeI commented May 30, 2024

this seems to just straight up nerf mining borgs

edit: if this gets merged id like to say that there should be a new mining borg upgrade that buffs them on lavaland or just have it by default so they dont get obliterated

@matttheficus
Copy link
Contributor

A few things from some adminzone testing:

  • You cannot chain "stamina stuns", EMP into flashspam does not seem to extend the disable like multi-batons do. I cannot vote in favor of this unless you can chainstun Cyborgs on Malf. If you can baton someone for a long ass time, you should be able to do the same for Cyborgs.

  • It takes two EMP Flashlight hits to take out a Cyborg - this really should be one considering its a Traitor Item IMO.

  • Cyborg "death" on cell remove takes IMMENSELY too long. We thought it was bugged in testing but it just takes ages. Not having a cell should be the equivalent of going into crit, IMO.

  • EMP Shotgun one-taps Cyborgs, this WILL become meta to stock the Armory with.

@tipoima
Copy link
Contributor

tipoima commented May 31, 2024

This just seems to make borgs even more annoying to deal with.

Now the armored AA validbot is fast enough that you can't outrun them, and you can't even stun them without them being able to alert the entire station. Emagging one is out of the question entirely.

@TravisAngeI
Copy link

This just seems to make borgs even more annoying to deal with.

Now the armored AA validbot is fast enough that you can't outrun them, and you can't even stun them without them being able to alert the entire station. Emagging one is out of the question entirely.

i get your last point related to the flash and emagging bit, but you know you already cant outrun them when they have vtec? (they can get it like 20-30 minutes into the round)

@tipoima
Copy link
Contributor

tipoima commented May 31, 2024

i get your last point related to the flash and emagging bit, but you know you already cant outrun them when they have vtec? (they can get it like 20-30 minutes into the round)

Honestly? I don't see borgs actually getting vtec that often (except malf rounds).
It's like the difference between old slime pots and just not having slowdown at all. Sometimes there are no robotics, sometimes the player is too lazy to go and check for upgrades, sometimes there are no mats.

On that note, what does vtec do with this PR?

@Fordoxia
Copy link
Contributor

i get your last point related to the flash and emagging bit, but you know you already cant outrun them when they have vtec? (they can get it like 20-30 minutes into the round)

Honestly? I don't see borgs actually getting vtec that often (except malf rounds). It's like the difference between old slime pots and just not having slowdown at all. Sometimes there are no robotics, sometimes the player is too lazy to go and check for upgrades, sometimes there are no mats.

On that note, what does vtec do with this PR?

Borgs get VTEC whenever they can get their hands on it, the slowdown is so painful.

Also, you can still outrun them by doing some damage to put them into painslow.

VTEC now caps the painslow.

@Fordoxia
Copy link
Contributor

this seems to just straight up nerf mining borgs

edit: if this gets merged id like to say that there should be a new mining borg upgrade that buffs them on lavaland or just have it by default so they dont get obliterated

I do incidentally have a mining borg PR open that will let mining borgs armour themselves for fauna protection.

@Cress67
Copy link

Cress67 commented Jun 1, 2024

Should probably include a GUI element to allow borgs to recognize how much "stamina" damage they have, seeing as they just made a separate one for carbons. It'd be helpful.

@Coolrune206
Copy link
Contributor

If a Cyborg with VTEC reaches the movement speed threshhold VTEC imposes by damage, then gets repaired, it seems they get stuck at the VTEC movement speed threshhold of 3.5. They'll be fine going to 3.4, can be repaired back to 2.5, but the moment it hits 3.5 they're on 3.5 foooreeeverrr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting approval This PR is waiting for approval internally Balance This PR will modify how effective something is or isnt Configuration Change This PR changes the game configuration files. Please run via the host. Feature This PR is a new addition to the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Sound This PR modifies the game sound Testmerge Active This PR is currently testmerged on production Testmerge Requested This PR has a pending testmerge request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet