Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pydantic dependency #3715

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

Netrvin
Copy link

@Netrvin Netrvin commented Mar 19, 2024

PR types

Bug fixes

PR changes

One of dependencies (pydantic)

Describe

When pydantic>=2.0, str cannot be directly None, it must be specified using Optional[str] or similar methods. If pydantic>=2.0 is used, it will lead to issues like the following:
In paddlespeech/server/restful/response.py, the TTSResponse's save_path: str = None will raise an error when save_path is None, thus causing an ErrorResponse to be returned.

pydantic>=2.0时,str不能为None
@CLAassistant
Copy link

CLAassistant commented Mar 19, 2024

CLA assistant check
All committers have signed the CLA.

@mergify mergify bot added the Installation label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants