[DistDialect] Add pir nd_mesh reshard function #64223
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
pkuzyc
force-pushed
the
pir_nd_mesh_reshard_func
branch
from
b9c8492
to
70a008f
Compare
| self.run_pr_to_rs_case() | ||
| self.run_pr_to_ss_case() | ||
| self.run_ss_to_ss_case() | ||
|
|
There was a problem hiding this comment.
add test for ss_to_rr, rs_to_sr (shard in same mesh dim and diff mesh dim) in future.
| dist_input, self._mesh1, output_placements | ||
| ) | ||
| dist_program = main_program.clone() | ||
| apply_reshard_pass(dist_program) |
There was a problem hiding this comment.
cross mesh scenario should call apply_partition_pass first to remove operation not belong to cur rank. (fix in next PR)
| # Calculate local shape. In nd_mesh_reshard, multiple tensor axis | ||
| # may be shard and it will call this 1-D s_to_r function on each | ||
| # axis. In this case, we should recompute the local and global shape. | ||
| out_local_shape = list(in_value.shape) |
There was a problem hiding this comment.
it might be better to regard the intermediate results within reshard transformation as local tensor and there is not need to assign dist_attr to it.
| test_pir_reshard_nd_mesh_func MODULES test_pir_reshard_nd_mesh_func ENVS | ||
| "http_proxy=;https_proxy=;PYTHONPATH=../..:${PADDLE_BINARY_DIR}/python") | ||
| set_tests_properties(test_pir_reshard_nd_mesh_func | ||
| PROPERTIES TIMEOUT "35" LABELS "RUN_TYPE=HYBRID") |
There was a problem hiding this comment.
timeout 35 might be to short, it is better to setting timeout as 90 for 4 gpus unitests take into account the overhead of communicators initialization.
There was a problem hiding this comment.
In local test it costs about 10s, it can be updated when adding more cases in the future.
PR Category
Auto Parallel
PR Types
New features
Description
Pcard-67164
Add nd_mesh reshard function in PIR, e.g. [Shard(0), Shard(1)] --> [Shard(1), Shard(0)]:
Find the tensor dimensions where the dims_mapping values differ between src_dist_attr and dst_dist_attr.
From higher to lower, convert the input tensor's non-replicated dimensions in step1 to replicated ([Shard(0), Shard(1)] --> [Shard(0), Replicate()] --> [Replicate(), Replicate()]):
Convert the replicated dimensions in step2 to the status in dst_dist_attr with corresponding ([Replicate(), Replicate()] --> [Replicate(), Shard(0)] --> [Shard(1), Shard(0)]):