New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong mapping when reading UBX-NAV-SAT messages #145

Open

bedaberner opened this issue Dec 7, 2023 · 1 comment

Contributor

bedaberner commented Dec 7, 2023 •

edited

It seems like "used" gets assigned the wrong value.

PX4-GPSDrivers/src/ubx.cpp

Line 1723 in 63990d2

    
           _satellite_info->used[sat_index]      = static_cast<uint8_t>(_buf.payload_rx_nav_svinfo_part2.flags & 0x01);

it checks bit 0 of the flags when according to the Interface Description (page 150/151) it should be bit 3.

Member

bkueng commented Dec 11, 2023

You are correct, can you create a pull request to fix it?

bedaberner mentioned this issue

ubx: fixed wrong mapping of UBX-NAV-SAT used parameter #146

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment