Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PUF-based flat file generation #31

Merged
merged 37 commits into from
Apr 22, 2024
Merged

Add PUF-based flat file generation #31

merged 37 commits into from
Apr 22, 2024

Conversation

nikhilwoodruff
Copy link
Collaborator

No description provided.

@nikhilwoodruff nikhilwoodruff self-assigned this Mar 27, 2024
@nikhilwoodruff nikhilwoodruff marked this pull request as draft April 17, 2024 11:39
@martinholmer
Copy link
Collaborator

@nikhilwoodruff, I think you need to add something to setup.py to avoid this GitHub error:

Screenshot 2024-04-17 at 5 33 11 PM

@nikhilwoodruff nikhilwoodruff marked this pull request as ready for review April 18, 2024 11:44
@nikhilwoodruff
Copy link
Collaborator Author

This PR is now passing tests that use the PUF microdata (stored on a private GitHub repository) to test the full PUF-PE microdata creates successfully (without reweighting for now- not incapable, just switched off because of the large runtime from installing PyTorch). I'm going to add unit tests that add sanity checks for each of the major variables of note identified by @donboyd5 in #46 so that future tests can catch these on the repo.

@nikhilwoodruff nikhilwoodruff merged commit f034ef4 into master Apr 22, 2024
2 checks passed
@nikhilwoodruff nikhilwoodruff deleted the dataset-update branch April 22, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants