Fix parameter error parsing in taxcalcio module #2625
Conversation
| @@ -689,11 +689,11 @@ def num_years(self): | |||
|
|
|||
| @property | |||
| def parameter_warnings(self): | |||
| return self.errors or "" | |||
| return self.errors or {} | |||
There was a problem hiding this comment.
The parameter errors are a dictionary that looks like this:
{'AMEDT_rt': ['AMEDT_rt[year=2021] 1.8 > max 1 ']}This change sets the default value to be a dictionary to keep the type consistent.
Codecov Report
@@ Coverage Diff @@
## master #2625 +/- ##
=======================================
Coverage 98.46% 98.47%
=======================================
Files 14 14
Lines 2611 2615 +4
=======================================
+ Hits 2571 2575 +4
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@hdoupe Looks very good and I was able to run all tests locally, plus get the proper error message from the json file given in Issue #2621. But before merging, can you get that new line of code covered? I think it just involves passing a reform file to the baseline argument in the new test you wrote, which does catch all the new lines for the reform file error messages. Thanks for your work on this! |
|
@jdebacker Looks like the code coverage test is passing now! Thanks for reviewing this. |
|
@hdoupe Thanks for getting that line covered -- and for the PR. Merging. |
Resolves #2622.