Fix notation #41
Merged
Fix notation #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have added some commits to fix the testing errors. Apologies for being slow to fix this. Let me know if you would like me to add anything else to this PR. |
|
@duncanhobbs All these changes LGTM. Just let me know when you are finished and I'll merge this PR. Thanks! |
|
@jdebacker I finished looking over the files and I think the notation is consistent with Hashimoto. |
|
Excellent. Thanks for another contribution @duncanhobbs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first pass at addressing issue #39 and adjusts the notation and docstrings in the files containing the equations to match the Hashimoto textbook.
Let me know if I need to add anything else to this PR.