Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jason's CI commits #81

Closed
wants to merge 3 commits into from
Closed

Conversation

hdoupe
Copy link
Collaborator

@hdoupe hdoupe commented Apr 6, 2021

Separates some of the CI commits @jdebacker added in #80, since the actions aren't running there for some reason.

@hdoupe
Copy link
Collaborator Author

hdoupe commented Apr 6, 2021

Hmmm, not running on this branch either....

@jdebacker
Copy link
Member

jdebacker commented Apr 7, 2021

@hdoupe I'm still unsure why the GH Action is not being run here. Maybe check: Settings -> Action permissions -- are settings there ok?

cc @MattHJensen in case @hdoupe doesn't have proper permissions in this repo

@hdoupe
Copy link
Collaborator Author

hdoupe commented Apr 7, 2021

Hmmm, looks ok to me:

image

@jdebacker
Copy link
Member

@hdoupe thanks for checking. Looks ok to me. Still puzzled. All questions I see this on internet seem to be idiosyncratic and "it just started working". Should we just try to merge this PR and see if it runs on a subsequent one?

hdoupe added a commit that referenced this pull request Apr 8, 2021
@hdoupe
Copy link
Collaborator Author

hdoupe commented Apr 8, 2021

@jdebacker closing #81 in favor of #82. I used the Actions tab to create the action and copy and pasted your work flow file. For some reason, that worked. 🤷‍♂️

@hdoupe hdoupe closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants