Feat/apple feed subclass #1013
Merged
Feat/apple feed subclass #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavis
reviewed
May 2, 2024
radical-ube
commented
May 9, 2024
radical-ube
commented
May 9, 2024
radical-ube
commented
May 9, 2024
radical-ube
commented
May 9, 2024
| @@ -0,0 +1,5 @@ | |||
| class Feed::AppleSubscriptionPolicy < ApplicationPolicy | |||
| def show? | |||
There was a problem hiding this comment.
maybe could leave this out until UI PR? i think this got added in a commit before realizing which branch i was in.
There was a problem hiding this comment.
Yep - I think you can delete this. You shouldn't need it at all, since you set self.model_name to Feed in the model. That causes the child-model to use the policy of the parent.
radical-ube
commented
May 9, 2024
cavis
requested changes
May 9, 2024
| @@ -0,0 +1,5 @@ | |||
| class Feed::AppleSubscriptionPolicy < ApplicationPolicy | |||
| def show? | |||
There was a problem hiding this comment.
Yep - I think you can delete this. You shouldn't need it at all, since you set self.model_name to Feed in the model. That causes the child-model to use the policy of the parent.
cavis
reviewed
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a
Feed::AppleSubscriptionsubclass in preparation for Apple Subscription UI work.