Skip to content

Commit

Permalink
Add testing for file name and audio format
Browse files Browse the repository at this point in the history
  • Loading branch information
radical-ube committed May 10, 2024
1 parent b1abbfd commit ef1cb31
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
2 changes: 1 addition & 1 deletion app/models/feed/apple_subscription.rb
Expand Up @@ -25,7 +25,7 @@ def set_defaults
self.slug ||= DEFAULT_FEED_SLUG
self.title ||= DEFAULT_TITLE
self.audio_format ||= DEFAULT_AUDIO_FORMAT
self.display_episodes_count ||= self.podcast&.default_feed&.display_episodes_count
self.display_episodes_count ||= podcast&.default_feed&.display_episodes_count
self.include_zones ||= DEFAULT_ZONES
self.tokens ||= DEFAULT_TOKENS

Expand Down
17 changes: 17 additions & 0 deletions test/models/feed/apple_subscription_test.rb
Expand Up @@ -9,21 +9,38 @@
it "cannot change the default properties once saved" do
apple_feed.title = "new apple feed"
apple_feed.slug = "new-apple-slug"
apple_feed.file_name = "new_file.xml"
apple_feed.audio_format = {f: "flac", b: 16, c: 2, s: 44100}
assert apple_feed.valid?
apple_feed.save!

apple_feed.title = "changed apple feed"
refute apple_feed.valid?
apple_feed.title = "new apple feed"
assert apple_feed.valid?

apple_feed.slug = "changed-apple-slug"
refute apple_feed.valid?
apple_feed.slug = "new-apple-slug"
assert apple_feed.valid?

apple_feed.file_name = "changed_file_name.xml"
refute apple_feed.valid?
apple_feed.file_name = "new_file.xml"
assert apple_feed.valid?

apple_feed.audio_format = {f: "wav", b: 128, c: 2, s: 44100}
refute apple_feed.valid?
apple_feed.audio_format = {f: "flac", b: 16, c: 2, s: 44100}
assert apple_feed.valid?
end

it "cannot have more than one apple feed on a single podcast" do
second_apple = build(:apple_feed, podcast: podcast)
assert second_apple.valid?

apple_feed.save!
assert apple_feed.valid?
refute second_apple.valid?
end

Expand Down

0 comments on commit ef1cb31

Please sign in to comment.