Skip to content

Commit

Permalink
Remove the noImp decorator in enclosure builder
Browse files Browse the repository at this point in the history
  • Loading branch information
svevang committed Apr 29, 2024
1 parent d6753b2 commit abdb44d
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 19 deletions.
1 change: 0 additions & 1 deletion app/models/apple/episode.rb
Expand Up @@ -242,7 +242,6 @@ def podcast

def enclosure_url
url = EnclosureUrlBuilder.new.base_enclosure_url(podcast, feeder_episode, private_feed)
url = EnclosureUrlBuilder.mark_no_imp(url)
EnclosureUrlBuilder.mark_authorized(url, show.private_feed)
end

Expand Down
6 changes: 0 additions & 6 deletions app/models/enclosure_url_builder.rb
Expand Up @@ -17,12 +17,6 @@ def self.mark_authorized(enclosure_url, feed)
add_query_param(enclosure_url, "auth", token)
end

# Marks the url as a `noImp`
# Used by Dovetail to skip the impression tracking
def self.mark_no_imp(enclosure_url)
add_query_param(enclosure_url, "noImp", "1")
end

def podcast_episode_url(podcast, episode, feed = nil)
feed ||= podcast.default_feed
prefix = feed.try(:enclosure_prefix)
Expand Down
4 changes: 2 additions & 2 deletions test/models/apple/episode_test.rb
Expand Up @@ -62,8 +62,8 @@
end

describe "#enclosure_url" do
it "should add a noImp query param" do
assert_match(/noImp=1/, apple_episode.enclosure_url)
it "should add auth query param" do
assert_match(/auth=/, apple_episode.enclosure_url)
end
end

Expand Down
10 changes: 0 additions & 10 deletions test/models/enclosure_url_builder_test.rb
Expand Up @@ -131,16 +131,6 @@
end

describe "a set of class methods to mark (annotate) enclosure urls" do
describe ".mark_no_imp" do
it "should add a noImp query param" do
assert_equal "http://example.com?noImp=1", EnclosureUrlBuilder.mark_no_imp("http://example.com")
end

it "should preserve existing query params" do
assert_equal "http://example.com?foo=bar&noImp=1", EnclosureUrlBuilder.mark_no_imp("http://example.com?foo=bar")
end
end

describe ".mark_authorized" do
let(:private_feed) { create(:private_feed, podcast: podcast) }
let(:feed_tok) { private_feed.tokens.first }
Expand Down

0 comments on commit abdb44d

Please sign in to comment.