Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Formatting #59

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[WIP]Formatting #59

wants to merge 7 commits into from

Conversation

bung87
Copy link
Contributor

@bung87 bung87 commented Nov 5, 2020

waiting for nimpretty compile project without problem.

@bung87
Copy link
Contributor Author

bung87 commented Nov 5, 2020

This won't work. The filestash file is the file as it appears in the editor for the user even if they haven't saved. We're only updating this based on the text changing events received from the editor. This would discard all changes the user have made without saving and mess up the internal cache file.

then we can take filestash as input file , and save formatted file to somewhere then read the content attach to response.

…ule, it only gets default conf with projecname
@AmjadHD
Copy link
Contributor

AmjadHD commented Jun 9, 2022

why did this stop ?

@bung87
Copy link
Contributor Author

bung87 commented Jun 9, 2022

this PR has two purposes. one for add code formatting feature, one for reduce the code complexity of nimlsp its self.
for code formatting , the nimpretty is not flexible to such a use case , it will cause compilation error as last commit message.
for reduce the code complexity of nimlsp , the nimlsp use alternative solution, also as nim became 1.6 version , it's not easy as before triggering nimlsp shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants