syntax check

[bung87]

• Bump version
• async server (async server #109)
• Minor style-fixes
• add syntax check before compile module

[PMunch]

Why is this done? The compiler should just error out early if there is a syntax error, right?

[bung87]

syntax check use less resource and faster than compile module, and when syntax wrong there's no need compile module, compile module will only issue an error and crash the server. while user typing code it's very easy trigger this.

[PMunch]

But part of LSP is based around getting information about what to type. Take a suggestion for example, you write var x = "Hello world"; echo x. and then hit tab I want my editor to issue a suggestion request, and the request to return things like e.g. len. But with this change the file would fail the syntax check and no information would be returned. This all works currently but would not work with this change..

[bung87]

I rarely use tab , in this case when typing x.l the editor still give suggestion.

[PMunch]

Of course x.l would still work, that's syntactically correct. But that's beside the point, this still disables features that works fine right now.

However I'm interested in the crash you mentioned. Do you have a small sample where I can see the server crashing without this feature?

[bung87]

I tried but hav't found yet, but I got new problem, I found syntax check is not reliable, it reports wrong error for me , it reports invalid indentation while that line is valid.