Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more Scipy integrators to handle stiff problems #2880

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

mkaguer
Copy link
Contributor

@mkaguer mkaguer commented Dec 22, 2023

Currently there is only one scipy integrator classes that uses RK45. I created a general integrator class that uses RK45 by default called ScipyIntegrator, this is the parent class. Then, I created child classes that inherit from this class but pass different solvers. I added two more solvers currently not available, BDF and LSODA. These solvers work for stiff problems.

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.8%. Comparing base (7c45c22) to head (d5ab2f0).
Report is 9 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev   #2880   +/-   ##
=====================================
  Coverage   89.7%   89.8%           
=====================================
  Files        148     148           
  Lines       8660    8670   +10     
=====================================
+ Hits        7776    7786   +10     
  Misses       884     884           

@ma-sadeghi ma-sadeghi self-requested a review December 24, 2023 21:35
Copy link
Member

@ma-sadeghi ma-sadeghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, can you add some unit tests?

@mkaguer
Copy link
Contributor Author

mkaguer commented Jan 7, 2024

Nice, can you add some unit tests?

Yea, I'll do that this week when I get back to work!

@mleot
Copy link

mleot commented Feb 7, 2024

I also have motivation to add more integrators to OpenPNM. I can help out with writing some of these unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants