Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Python version to 3.10 #61

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

Liquid369
Copy link
Member

@Liquid369 Liquid369 commented Apr 8, 2024

This will update our GitHub actions to use Python 3.10 instead of the current version 3.7.

Python EOL's are intended 5 years after their release date. Python 3.7 was released in June 2018. Therefore the EOL was June 2023. As it is now 2024, we are bumping to Python 3.10 for wider compatibility and support.

Note: Windows failure is from PyQt lib which will be/is updated in #60

Copy link
Contributor

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just semantics, but AFAIK the python-version argument doesn't need to be quoted from what i've seen in the documentation.

.github/workflows/main.yaml Show resolved Hide resolved
.github/workflows/main.yaml Show resolved Hide resolved
@Liquid369
Copy link
Member Author

maybe just semantics, but AFAIK the python-version argument doesn't need to be quoted from what i've seen in the documentation.

You are right but I forgot to add the reasoning, I had tried without and we hit an issue of it saying 'python 3.1'
So I did some searching and found its actually a bug actions/runner#1989
Now by adding quotes we can get 3.10 to install properly in GitHub Actions

@Fuzzbawls
Copy link
Contributor

maybe just semantics, but AFAIK the python-version argument doesn't need to be quoted from what i've seen in the documentation.

You are right but I forgot to add the reasoning, I had tried without and we hit an issue of it saying 'python 3.1' So I did some searching and found its actually a bug actions/runner#1989 Now by adding quotes we can get 3.10 to install properly in GitHub Actions

yeah, i just found that out myself too. stupid limitation of GA. so disregard my initial comment :)

Copy link
Contributor

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6423c0b

@Fuzzbawls Fuzzbawls merged commit fbef339 into PIVX-Project:master Apr 16, 2024
3 of 4 checks passed
@Fuzzbawls Fuzzbawls added this to the 0.6.4 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants