Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Version for phpcodesniffer-composer-installer #1238

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zf2timo
Copy link

@zf2timo zf2timo commented Nov 4, 2020

To use DealerDirect/phpcodesniffer-composer-installer with composer 2.0 the author suggest to use the version "0.7.0"

I updated this in the Readme.

To use `DealerDirect/phpcodesniffer-composer-installer` with composer 2.0 the author suggest to use the version "0.7.0"

I updated this in the Readme.
@jrfnl
Copy link
Member

jrfnl commented Nov 4, 2020

Hi @zf2timo Thanks for your willingness to contribute to this repo.

I'm a bit in two minds about this change.
We're currently working on PHPCompatibility 10.0.0 and as of that version, the DealerDirect Composer plugin will actually be a requirement for PHPCompatibility and the recommendation will be to remove it from your own composer.json.

This has already been put in place, I just haven't updated the README.md yet so as not to confuse people for the time being, as the "new" install instructions won't apply until we release version 10.0.0.

So yes, this may be useful for people for now, however, it would only show up in the readme on GitHub, not on Packagist, as we wouldn't update the last release 9.3.5 and Packagist would still show the version from 9.3.5 (or whatever release is selected) and the change would be removed again when we update the install instructions for the 10.0.0 release.

What do you think ?

@zf2timo
Copy link
Author

zf2timo commented Nov 4, 2020

Hi @jrfnl,

I just found this and the DealerDirect/phpcodesniffer-composer-installer project today. While reading the documentation of both project, I noticed DealerDirect/phpcodesniffer-composer-installer suggest to use version 0.7.0 to be compatible with composer 2.
So I thought, changing the documentation could be helpful for other users.

I don't think, this will be a problem in the future. When in version 10.0.0 the library is suggested by composer the info just show up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants