New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: @PhpCsFixer
ruleset - normalize implicit backslahes in single quoted strings
#7965
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aebabe8
to
8fe7f1d
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@PhpCsFixer
ruleset - normalize implicit backslahes in single quoted strings
8fe7f1d
to
cd21ad8
Compare
cd21ad8
to
02d96a9
Compare
Can this PR be approved? It is unambiguous that backslashes are commonly & significantly not quoted * and thus this the new config is the only one preferred. * here before #7786, Symfony, Lavarel, ... |
if you say this is Symfony best practice, add it to Sf ruleset and not Fixer's own one. |
bc4c592
to
3a5473c
Compare
3a5473c
to
1c460de
Compare
Please merge this PR. |
@mvorisek I think @keradus' comment was not addressed. @nicolas-grekas is this something you would like to have in the Symfony ruleset? |
as requested in #7786 (review)