Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Allow None recovery_target #121

Merged
merged 2 commits into from May 20, 2024
Merged

ENH: Allow None recovery_target #121

merged 2 commits into from May 20, 2024

Conversation

szwiep
Copy link
Contributor

@szwiep szwiep commented Apr 16, 2024 •
edited

  • Allow setter to use None in RA
  • Allow None in compute_metrics
  • Add test that passing None works fine
  • Add test for err if metric that needs recovery_target is called but is None

@szwiep szwiep requested a review from KavlinClein April 16, 2024 23:40
@szwiep szwiep self-assigned this Apr 16, 2024
@szwiep szwiep linked an issue Apr 16, 2024 that may be closed by this pull request
ENH: Make recovery target optional #115
Closed
@szwiep szwiep changed the title ENH: Allow None recovery_target WIP: Allow None recovery_target Apr 18, 2024
@szwiep szwiep changed the title WIP: Allow None recovery_target ENH: Allow None recovery_target May 20, 2024
@szwiep szwiep merged commit 601ce7d into main May 20, 2024
2 checks passed
@szwiep szwiep deleted the 115-enh-recovery-target-optional branch May 20, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KavlinClein KavlinClein Awaiting requested review from KavlinClein

Assignees

@szwiep szwiep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Make recovery target optional
1 participant
@szwiep