Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed default sprite size to 32 to work better with large datasets #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

changed default sprite size to 32 to work better with large datasets #118

wants to merge 1 commit into from

Conversation

contractorwolf
Copy link
Contributor

I changed the default sprite size to 32 to fix issues that I was having facets crash when trying to display a dataset with 33 columns and 90k records. It was suggested by @jimbojw to set the sprite to 32 pixels, so here is the PR for that. The Issue (reported by me) is located here:
#115 (comment)

I tested the suggest change on my dataset (no longer crashes) and tested just this change locally on the default dataset in facets. Let me know if there is anything else I need to do.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@contractorwolf
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jimbojw
Copy link
Collaborator

jimbojw commented Apr 6, 2018

Thanks for sending us a PR. Unfortunately, the smaller the sprite size, the fewer pixels are available for rendering text, causing it to appear pixelated. I'm concerned that this would make smaller data sets look worse. Is there any way we could dynamically compute a good default based on the data set size?

@contractorwolf
Copy link
Contributor Author

@jimbojw yeah I can do that, I just worry about adding the additional complexity to a code sample. This is the first time I really used this but for mine I was just using "credit score" to fill the display which is only 3 digits and looks fine at 32px, but i don't know what kind of items other people would be filling each dot with. Can you give me some examples that you are using on the "display" so I can imagine it better? Ill adjust this PR, what would you suggest the breakpoint should be when switching between 64 and 32px? 50k records?

@contractorwolf
Copy link
Contributor Author

contractorwolf commented Apr 7, 2018

@jimbojw I made a new PR integrating your concerns and making it dynamic:
#119

@contractorwolf
Copy link
Contributor Author

let me know if that doesnt work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants