This repository has been archived by the owner on Jun 19, 2021. It is now read-only.
Temp. plant renderer and treegen fixes/improvements #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is now ready for a first look
This has already proven useful to generate trees and should probably be used by every worldgen feature to come
jonas-schievink
changed the title
| loc_seed.hash(&mut fnv); | ||
| let rng_seed = fnv.finish(); | ||
| let seed0 = (rng_seed >> 32) as u32; | ||
| let seed1 = rng_seed as u32; |
There was a problem hiding this comment.
I hate this as cast more every day. It would be way nicer to express your intend clearly in the code, like let seed1: u32 = rng_seed.truncate();. Ok but I guess this can't be improved right now 😞
|
I made a few line comments. Otherwise this PR looks nice. I just checked it out to see it in action ... neat 😮 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ready to go now!