Fix indentation rule false positive #1563
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
Nov 13, 2023
| @@ -136,6 +137,10 @@ public function check(Lines $lines, int $number, string $filename): ViolationInt | |||
| $minus = 3; | |||
| } | |||
|
|
|||
| if ((new PhpHelper())->isPartOfTable($lines, $number)) { | |||
There was a problem hiding this comment.
Tests are broken, because sections https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#sections are considered as table in RstParser
Do you have an idea ?
There was a problem hiding this comment.
Indeed, I believe this is the precise issue I encountered when I previously attempted to address this situation.
Lets not invest too much time then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.