Suppress exceptions from HubLifetimeManager.Dispose() #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented full DisposeAsync pattern. Refactored.
JorgeCandeias
requested review from
claylaut,
galvesribeiro,
zeus82 and
andrund
as code owners
Implemented full DisposeAsync pattern. Refactored.
…pose' of https://github.com/JorgeCandeias/SignalR.Orleans into feature/suppress-exceptions-from-hublifetimemanager-dispose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses exceptions being thrown from
OrleansHubLifetimeManager<T>while disposing itself.It also implements the full async disposable pattern as to be more friendly with the NET6+ Service Provider.
The reason for this PR is that this was causing a red herring for us, by hiding the root cause of another issue that was preventing a silo from starting.
Please note that this PR is based on #156 as we already have that in production. Therefore please address that one first.