Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token Merger Deploy Script #418

Merged
merged 27 commits into from
May 22, 2024
Merged

Token Merger Deploy Script #418

merged 27 commits into from
May 22, 2024

Conversation

DanielVF
Copy link
Member

No description provided.

@DanielVF DanielVF changed the base branch from master to DanielVF/reclaimAfter May 14, 2024 21:40
@DanielVF
Copy link
Member Author

Starting test:

IS_FORK=true forge script --target-contract OgnOgvMigrationScript --rpc-url="URL_HERE" -vvvv script/deploy/mainnet/010_OgnOgvMigrationScript.sol

@DanielVF
Copy link
Member Author

Long term goal is to have the base script expose a registry for deployed contracts.

This way when you make a fork test, you run the script, then use the registry to get to the latest deployed contract addresses.

Also, the idea would be to return a governance object that knows how to both execute its commands in a fork test, but also return something useful for submitting to governance.

We'll have to support both governance proposals AND multisig to direct to timelock for these migrations. Probably our highest priority though is getting some good fork tests to run after these deploys run.

return;
}

isForked = vm.envOr("IS_FORK", false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vm.isContext(VmSafe.ForgeContext.ScriptDryRun) might be a much cleaner way than environment variables for this one. Will make this change

Base automatically changed from DanielVF/reclaimAfter to master May 16, 2024 19:34
@DanielVF DanielVF changed the title Foundry based deploy script Token Merger Deploy Script May 22, 2024
@shahthepro shahthepro merged commit 012b8ab into master May 22, 2024
4 checks passed
@shahthepro shahthepro deleted the DanielVF/DeployFiles branch May 22, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants