Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP TryLSD strategy #1911

Draft
wants to merge 16 commits into
base: nicka/amo-frxeth
Choose a base branch
from
Draft

WIP TryLSD strategy #1911

wants to merge 16 commits into from

Conversation

naddison36
Copy link
Collaborator

If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@rafaelugolini rafaelugolini temporarily deployed to preview-ousd-nicka-tryl-umpcwa November 6, 2023 12:37 Inactive
Copy link

github-actions bot commented Nov 6, 2023

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 7c374d3

@naddison36 naddison36 changed the title TryLSD strategy WIP TryLSD strategy Nov 7, 2023
@rafaelugolini rafaelugolini temporarily deployed to preview-ousd-nicka-tryl-umpcwa November 8, 2023 08:27 Inactive
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 161 lines in your changes are missing coverage. Please review.

Comparison is base (3f367ae) 69.31% compared to head (7c374d3) 64.68%.

Files Patch % Lines
...acts/contracts/strategies/ConvexCryptoStrategy.sol 0.00% 140 Missing ⚠️
...ontracts/strategies/curve/CurveCryptoFunctions.sol 0.00% 21 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##           nicka/amo-frxeth    #1911      +/-   ##
====================================================
- Coverage             69.31%   64.68%   -4.64%     
====================================================
  Files                    64       66       +2     
  Lines                  3155     3319     +164     
  Branches                786      825      +39     
====================================================
- Hits                   2187     2147      -40     
- Misses                  965     1169     +204     
  Partials                  3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants