Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Generalised AMOs for Curve and Balancer #1806

Closed
wants to merge 176 commits into from

Conversation

naddison36
Copy link
Collaborator

If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Added Withdrawal event to ConvexEthMetaStrategy.withdrawAll
* Coin indexes using constants

* Changed the OETH AMO to use immutables

* Made the immutables and constants public
Generated new OETH AMO strategy diagrams
Add output config to the curve tasks amoStrat and curvePool to use either console.log or the debugger's log
Reuse the amoStrat subtask in the OETH AMO fork tests
Got the repeg tests working
Added missing Deposit event to mintAndAddOTokens
Added to AMO fork tests
@naddison36 naddison36 marked this pull request as ready for review October 30, 2023 12:35
@naddison36 naddison36 marked this pull request as draft October 30, 2023 12:35
Copy link

AMO behaviour tests

@naddison36 naddison36 changed the base branch from master to nicka/convex-frxeth-weth-libs November 9, 2023 04:23
@DanielVF
Copy link
Member

DanielVF commented May 8, 2024

As we move toward Simplified OETH, we have no immediate plans for these AMOs.

@DanielVF DanielVF closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Works related to contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants