Release v1.8.3 (Lombiq Technologies: OCORE-162) #15826
Conversation
Piedone
requested review from
MikeAlhayek,
hishamco and
sebastienros
and removed request for
agriffard
|
I'd need an urgent review here, please. Then I'll do the rest of the release. |
Piedone
changed the title
| @@ -17,7 +17,7 @@ The below table lists the different .NET libraries used in Orchard Core: | |||
| | [Fluid.Core](https://github.com/sebastienros/fluid) | .NET Liquid template engine. | 2.5.0 | [MIT](https://github.com/sebastienros/fluid/blob/dev/LICENSE) | | |||
| | [GraphQL](https://github.com/graphql/graphiql) | GraphiQL & GraphQL. | 4.6.1 | [MIT](https://github.com/graphql/graphiql/blob/main/LICENSE) | | |||
| | [HtmlSanitizer](https://github.com/mganss/HtmlSanitizer) | Cleans HTML to avoid XSS attacks. | 8.1.812-beta | [MIT](https://github.com/mganss/HtmlSanitizer/blob/master/LICENSE.md) | | |||
| | [Image Sharp](https://github.com/SixLabors/ImageSharp.Web) | Middleware for ASP.NET-Core for image manipulation. | 3.1.0 |[Apache-2.0](https://github.com/SixLabors/ImageSharp.Web/blob/master/LICENSE) | | |||
| | [ImageSharp](https://github.com/SixLabors/ImageSharp.Web) | Middleware for ASP.NET-Core for image manipulation. | 3.1.2 |[Apache-2.0](https://github.com/SixLabors/ImageSharp.Web/blob/master/LICENSE) | | |||
There was a problem hiding this comment.
I suggest merging this PR #15822 too
There was a problem hiding this comment.
That's not applicable since those packages are only used in main.
There was a problem hiding this comment.
While ImageSharp version is 3.1.2 I think it's updated recently, right?
There was a problem hiding this comment.
Sorry, I don't understand. Note that this is a patch release on top of 1.8.2. Anything done in main since that is intentionally not included.
There was a problem hiding this comment.
Anything done in the main since that is intentionally not included.
I see, but how was the ImageShape version updated above, while it was merged last week #15767
There was a problem hiding this comment.
That PR was merged to main. This PR is not started from main, but release/1.8.3. We don't want to release main, since that contains a lot of stuff for 1.9 and it's not ready yet. We do want to release the two dependency updates in this PR ASAP and not wait for anything else, since they're security vulnerabilities. So, the update to the version of these needed to be done a second time here too.
| @@ -8,7 +8,7 @@ The below table lists the different .NET libraries used in Orchard Core: | |||
| | [AWSSDK S3](https://github.com/aws/aws-sdk-net) | AWS SDK for .NET. | 3.7.104.11 |[Apache-2.0 license](https://github.com/aws/aws-sdk-net/blob/master/License.txt) | | |||
| | [AWSSDK SecurityToken](https://github.com/aws/aws-sdk-net) | AWS SDK for .NET. | 3.7.101.60 |[Apache-2.0 license](https://github.com/aws/aws-sdk-net/blob/master/License.txt) | | |||
| | [AWSSDK Extensions Setup](https://github.com/aws/aws-sdk-net) | AWS SDK for .NET. | 3.7.7 |[Apache-2.0 license](https://github.com/aws/aws-sdk-net/blob/master/License.txt) | | |||
| | [Azure Identity](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/README.md) | Azure Active Directory token authentication support. | 1.10.4 |[MIT](https://github.com/Azure/azure-sdk-for-net/blob/master/LICENSE.txt) | | |||
| | [Azure Identity](https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/identity/Azure.Identity/README.md) | Azure Active Directory token authentication support. | 1.11.2 |[MIT](https://github.com/Azure/azure-sdk-for-net/blob/master/LICENSE.txt) | | |||
There was a problem hiding this comment.
If these changes are coming from an existing PR. I think you should backport that PR into this branch. The Release v1.8.3 PR should contain only administration docs.
There was a problem hiding this comment.
I don't see much point in finding those PRs and cherry-picking them for changes in version numbers.
Fix #15824