Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cloning the AutoroutePart pattern in the localized content #15810

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+82 −52
Open

Avoid cloning the AutoroutePart pattern in the localized content #15810

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a491b55
Avoid cloning the AutoPart pattern in the localized content
hishamco Apr 23, 2024
77d190b
Merge branch 'main' into hishamco/issue-15805
hishamco May 1, 2024
4e8b6cb
Address feedback
hishamco May 1, 2024
9abfd72
Merge branch 'main' into hishamco/issue-15805
hishamco May 1, 2024
96a224d
Merge branch 'main' into hishamco/issue-15805
hishamco May 2, 2024
69793d2
Apply suggestions from code review
hishamco May 2, 2024
143ec74
Merge branch 'main' into hishamco/issue-15805
hishamco May 2, 2024
2f6f73b
Move AutorouteContentLocalizationHandler to Autoroute module
hishamco May 2, 2024
11280d1
Address feedback
hishamco May 2, 2024
62cc6b1
Merge branch 'main' into hishamco/issue-15805
hishamco May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/OrchardCore.Modules/OrchardCore.ContentLocalization/DefaultContentLocalizationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Threading.Tasks;
using Microsoft.AspNetCore.Localization;
using Microsoft.Extensions.Logging;
using OrchardCore.Autoroute.Models;
using OrchardCore.ContentLocalization.Handlers;
using OrchardCore.ContentLocalization.Models;
using OrchardCore.ContentLocalization.Records;
Expand Down Expand Up @@ -102,6 +103,12 @@ public async Task<ContentItem> LocalizeAsync(ContentItem content, string targetC
clonedPart.LocalizationSet = localizationPart.LocalizationSet;
clonedPart.Apply();

// Clearing the autopart path to regenerate the permalink automatically
if (cloned.Has<AutoroutePart>())
{
cloned.Content.AutoroutePart.Path = null;
}
Piedone marked this conversation as resolved.
Show resolved Hide resolved

var context = new LocalizationContentContext(cloned, content, localizationPart.LocalizationSet, targetCulture);

await Handlers.InvokeAsync((handler, context) => handler.LocalizingAsync(context), context, _logger);
Expand Down
1 change: 1 addition & 0 deletions ...rchardCore.Modules/OrchardCore.ContentLocalization/OrchardCore.ContentLocalization.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<ItemGroup>
<ProjectReference Include="..\..\OrchardCore\OrchardCore.Admin.Abstractions\OrchardCore.Admin.Abstractions.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.Apis.GraphQL.Abstractions\OrchardCore.Apis.GraphQL.Abstractions.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.Autoroute.Core\OrchardCore.Autoroute.Core.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentLocalization.Abstractions\OrchardCore.ContentLocalization.Abstractions.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentManagement.Abstractions\OrchardCore.ContentManagement.Abstractions.csproj" />
<ProjectReference Include="..\..\OrchardCore\OrchardCore.ContentManagement.GraphQL\OrchardCore.ContentManagement.GraphQL.csproj" />
Expand Down