Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrects the mapping of types to features in ITypeFeatureProvider #15793

Merged
merged 31 commits into from
May 24, 2024
Merged

Corrects the mapping of types to features in ITypeFeatureProvider #15793

merged 31 commits into from
May 24, 2024

Commits on Apr 19, 2024

  1. Update type mappings in TypeFeatureProvider when the service collecti… 

    …ons are being build.
    @gvkries
    gvkries committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0ca7aae View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary FeatureEntry type.

    @gvkries
    gvkries committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    f0834d1 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Moves populating the ITypeFeatureProvider completely into the `Shel… 

    …lContainerFactory`. Before, that responsibility was split between the `ExtensionManager` and shell container factory.
    @gvkries
    gvkries committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7f5352d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into gvkries/di-dependencies-15782

    @gvkries
    gvkries committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3202617 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'gvkries/di-dependencies-15782' of https://github.com/gv… 

    …kries/OrchardCore into gvkries/di-dependencies-15782
    @gvkries
    gvkries committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3350463 View commit details
    Browse the repository at this point in the history

  4. Fixes unit tests.

    @gvkries
    gvkries committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b65b1e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Changes the ITypeFeatureProvider to allow types that are used by mu… 

    …ltiple features.
    @gvkries
    gvkries committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6e509a6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into gvkries/di-dependencies-15782

    @gvkries
    gvkries committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    4ed7ab8 View commit details
    Browse the repository at this point in the history

  3. Added a basic unit test.

    @gvkries
    gvkries committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1a74496 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge branch 'main' into gvkries/di-dependencies-15782

    @Piedone
    Piedone committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2a71dfe View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Merge branch 'main' into gvkries/di-dependencies-15782

    @gvkries
    gvkries committed May 6, 2024
    Configuration menu
    Copy the full SHA
    4b20596 View commit details
    Browse the repository at this point in the history

  2. Update src/OrchardCore/OrchardCore/Extensions/ExtensionManager.cs 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @gvkries @Piedone
    gvkries and Piedone committed May 6, 2024
    Configuration menu
    Copy the full SHA
    8d78e67 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Merge branch 'main' into gvkries/di-dependencies-15782

    @gvkries
    gvkries committed May 15, 2024
    Configuration menu
    Copy the full SHA
    18812a7 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Merge branch 'main' into gvkries/di-dependencies-15782

    @gvkries
    gvkries committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b93df1c View commit details
    Browse the repository at this point in the history

  2. Adds GetFeatureForDependency() back and also introduces GetExtensionF… 

    …orDependency() on the ITypeFeatureProvider interface.
    @gvkries
    gvkries committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a4a3c85 View commit details
    Browse the repository at this point in the history

  3. Formatting.

    @gvkries
    gvkries committed May 16, 2024
    Configuration menu
    Copy the full SHA
    471c62a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
Co-authored-by: Mike Alhayek <mike@crestapps.com>
    @gvkries @Piedone @MikeAlhayek
    3 people committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b6ec58e View commit details
    Browse the repository at this point in the history

  2. React to code review.

    @gvkries
    gvkries committed May 17, 2024
    Configuration menu
    Copy the full SHA
    ca4e21b View commit details
    Browse the repository at this point in the history

  3. Suggestions from code review applied.

    @gvkries
    gvkries committed May 17, 2024
    Configuration menu
    Copy the full SHA
    85b9421 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into gvkries/di-dependencies-15782

    @gvkries
    gvkries committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2335466 View commit details
    Browse the repository at this point in the history

  5. Removes the FeatureAttribute from classes that are now automatically … 

    …assigned to the correct feature.
    @gvkries
    gvkries committed May 17, 2024
    Configuration menu
    Copy the full SHA
    58fe1e6 View commit details
    Browse the repository at this point in the history

  6. Typo

    @gvkries
    gvkries committed May 17, 2024
    Configuration menu
    Copy the full SHA
    1c0d8a3 View commit details
    Browse the repository at this point in the history

  7. Check if feature is enabled when displaying permissions registered fo… 

    …r multiple features.
    @gvkries
    gvkries committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c4e8a3e View commit details
    Browse the repository at this point in the history

  8. Added FeatureAttribute back for some classes that should belong to th… 

    …e default application feature.
    @gvkries
    gvkries committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b6a988a View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Use the last enabled feature instead of the first one in the permissi… 

    …ons editor.
    @gvkries
    gvkries committed May 19, 2024
    Configuration menu
    Copy the full SHA
    ed7f37e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into gvkries/di-dependencies-15782

    @gvkries
    gvkries committed May 19, 2024
    Configuration menu
    Copy the full SHA
    3cb2504 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Merge branch 'main' into gvkries/di-dependencies-15782

    @gvkries
    gvkries committed May 23, 2024
    Configuration menu
    Copy the full SHA
    4439345 View commit details
    Browse the repository at this point in the history

  2. Update AdminController.cs

    @sebastienros
    sebastienros committed May 23, 2024
    Configuration menu
    Copy the full SHA
    e73cb94 View commit details
    Browse the repository at this point in the history

  3. Update src/OrchardCore/OrchardCore.Abstractions/Extensions/Features/I… 

    …TypeFeatureProvider.cs

Co-authored-by: Zoltán Lehóczky <zoltan.lehoczky@lombiq.com>
    @sebastienros @Piedone
    sebastienros and Piedone committed May 23, 2024
    Configuration menu
    Copy the full SHA
    a6bd9cd View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge branch 'main' into gvkries/di-dependencies-15782

    @gvkries
    gvkries committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c8d9db7 View commit details
    Browse the repository at this point in the history

  2. minor cleanup and add documentation

    @MikeAlhayek
    MikeAlhayek committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5037727 View commit details
    Browse the repository at this point in the history