Fix frontend assets being outdated (Lombiq Technologies: OCORE-158) #15735
Conversation
|
Thanks for the approve, but I'm not done yet :). The build validation fails still. It turns out that the Gulp build for Trumbowyg plugins is nondeterministic and you can randomly get differently ordered files in the concatenated result. I think I fixed that, but there's still something else, most possibly some line ending difference. |
|
Everything else pass on CI so approved 😉 |
|
Hey Zoltan, I have a new asset builder that can make use of Parcel, Webpack, Rollup and that should eventually work better than this gulp file. |
|
The long-term solution I'd argue would be to build static files on build too. However, that needs all contributors to go through the painful setup of Node, even if they never touch static files. This is what we do with Node.js Extensions though. Can you please elaborate? Do you have a PoC somewhere? |
This reverts commit 4d08c57.
|
Thank you! @Skrypt would you like to add anything, or veto merging this? |
|
In the US, we like to use veto just because :). Given that last comment @Skrypt had I veto to merge it so the 1.9 milestone list will shrink Okay, that's to much politics |
|
|
|
Seems like a political move :D. |
|
we'll when you have the right to veto, then you can abuse it's power and no one can veto your veto 😜 |
|
|
|
Are you guys trolling me there? |
|
I'm joking with Mike, but I genuinely asked for your feedback under #15735 (comment). Certainly no offense intended. Sorry if it came over like that. |
|
Yeah, it sounded like if I was abusing my contributor role by blocking PR's and altering them to meet some requirements. @MikeAlhayek All of this starts with trolling me on : "should I test this?" on meetings, PR's and then here by making allusions. I don't like where this discussion is going to be honest. I was really not making a joke when I said last week that it is maddening when you need to clean up everyone's PR after they get merged. This is why we generally block them. Apologies accepted but if there's anything else please do it in private. Thanks |
|
It wasn't really meant against you like that. Let me try to clear it up; I'll kill the joke by explaining it (including Mike's part, how I understand it, but of course I don't speak for him), but of course, a joke is only good if everyone can laugh at it, and apparently this wasn't a good one. And it's better to talk through conflicts too much than too little.
Mike, please add anything if you deem necessary. I hope this clears things up :). The lesson learned here is probably that we should stick to jokes that are understandable for everyone within this professional context, and leave out the memes even slightly related to politics. I don't know about the meeting you refer to, so I'm probably missing some context here that shines a different light on the above exchange, but as for me, it didn't really have anything to do with it. Can you tell which meeting that was BTW? If a Tuesday one, then I'll watch the recording. And I think that your work as a core contributor is very valuable. If I ever find a more general issue with your activities then I'll be sure to bring that up privately and directly, not publicly and in such roundabout ways. I ask everyone to do the same for me too. |
|
Ok thanks, I'm just making links where I shouldn't. I appreciate the explanation. |
|
Glad to hear we have it settled! |
Fix #15726
Fix #11916
Fix #7835
Checked the login, admin, and Trumbowyg editor, and they all appear to be fine still.