Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdig 0.37.0 #15705

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Markdig 0.37.0 #15705

wants to merge 3 commits into from

Conversation

@Piedone
Copy link
Member

Piedone commented Apr 9, 2024

How's best to test this?

@agriffard
Copy link
Member Author

Adding a Markdown Field to a content type and testing this example :

> [!CAUTION] 
> This is the newly generated CAUTION block 
>  
> And this is the second paragraph

According to xoofx/markdig#782 (PR included in https://github.com/xoofx/markdig/releases/tag/0.37.0), it should render this:

<div class="markdown-alert markdown-alert-caution alert alert-danger" role="alert">
<p>This is the newly generated CAUTION block</p>
<p style="margin-bottom: 0">And this is the second paragraph</p>
</div>

but it is as if the change was not taken into account and the example output is still:

<div class="markdown-alert markdown-alert-caution">
<p class="markdown-alert-title">Caution</p>
<p>This is the newly generated CAUTION block</p>
<p>And this is the second paragraph</p>
</div>

@Piedone
Copy link
Member

Piedone commented Apr 10, 2024

That's not what I see happening:

image

Copy link

This pull request has merge conflicts. Please resolve those before requesting a review.

@MikeAlhayek
Copy link
Member

@agriffard is this something ready to merge?

@Piedone
Copy link
Member

Piedone commented May 3, 2024

No, see above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants